Skip to content

Fix protolayout warning by updating its version #14797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2025
Merged

Fix protolayout warning by updating its version #14797

merged 3 commits into from
Oct 24, 2025

Conversation

@irfano
Copy link
Contributor

@irfano irfano commented Oct 21, 2025

Closes WOOMOB-1552

Description

This PR updates the protolayout-expression version used transitively by the Wear app through the Horologist library. See WOOMOB-1552 for more details about the known issues with protolayout-expression:1.0.0-beta01.

Steps to reproduce

  • Launch Wear app.
  • Run ./gradlew assembleDebug --scan and in the result report, check dependencies and verify that androidx.wear.protolayout:protolayout-expression:1.0.0-beta01 is forced to
    1.2.1.

The tests that have been performed

Tested the Wear app to ensure it compiles and launches without any issues.

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

irfano added 2 commits October 21, 2025 20:41
@irfano
Force androidx.wear.protolayout to 1.2.1
89e2388 
Upgrades `androidx.wear.protolayout` to version `1.2.1` to resolve known issues present in the version previously used by Horologist.
@irfano
Remove unused wear dependencies
97ae0ce
@irfano irfano added this to the 23.5 ❄️ milestone Oct 21, 2025
@irfano irfano requested a review from a team as a code owner October 21, 2025 18:27
@irfano irfano requested review from malinajirka and removed request for a team October 21, 2025 18:27
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 21, 2025 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 23.5 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.
1 Message
📖 This PR contains changes to RELEASE-NOTES.txt.
Note that these changes won't affect the final version of the release notes as this version is in code freeze.
Please, get in touch with a release manager if you want to update the final release notes.

Generated by 🚫 Danger

@irfano irfano requested review from AdamGrzybkowski, JorgeMucientes and hichamboushaba and removed request for malinajirka October 21, 2025 18:36
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 21, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit597f812
Direct Downloadwoocommerce-wear-prototype-build-pr14797-597f812.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 21, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit597f812
Direct Downloadwoocommerce-prototype-build-pr14797-597f812.apk

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.08%. Comparing base (2ae1831) to head (597f812).

Additional details and impacted files 
@@               Coverage Diff               @@
##             release/23.5   #14797   +/-   ##
===============================================
  Coverage           38.08%   38.08%           
  Complexity           9998     9998           
===============================================
  Files                2119     2119           
  Lines              119170   119170           
  Branches            16228    16228           
===============================================
+ Hits                45384    45385    +1     
+ Misses              69207    69206    -1     
  Partials             4579     4579

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JorgeMucientes JorgeMucientes self-assigned this Oct 22, 2025
JorgeMucientes
JorgeMucientes approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@JorgeMucientes JorgeMucientes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this @irfano. Changes look good.
I just left a question about the removed dependencies

PS: I'll create a new wearable release candidate once this is merged

gradle/libs.versions.toml
androidx-test-uiautomator = '2.3.0'
androidx-transition = '1.6.0'
androidx-wear-compose = '1.4.0'
androidx-wear-tiles = '1.3.0'
Copy link
Contributor

@JorgeMucientes JorgeMucientes Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this unused?

Copy link
Contributor Author

@irfano irfano Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 🤔 They're defined in libs.versions.toml for androidx-wear-tiles-main and androidx-wear-tiles-material, but they're not used anywhere.
Implementation for those were removed recently (https://github.com/woocommerce/woocommerce-android/pull/14710/files) but those left behind in libs.versions.toml.

@irfano irfano merged commit b57eeaa into release/23.5 Oct 24, 2025
16 checks passed
@irfano irfano deleted the fix/protolayout-warning branch October 24, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JorgeMucientes JorgeMucientes JorgeMucientes approved these changes

@hichamboushaba hichamboushaba Awaiting requested review from hichamboushaba

@AdamGrzybkowski AdamGrzybkowski Awaiting requested review from AdamGrzybkowski

Assignees

@JorgeMucientes JorgeMucientes

Labels

dependency update

Projects

None yet

Milestone

23.5

Development

Successfully merging this pull request may close these issues.

6 participants

@irfano @dangermattic @wpmobilebot @codecov-commenter @JorgeMucientes